New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Student voice: Add self-reflection on Q2 next to grades #2384

Merged
merged 14 commits into from Jan 29, 2019

Conversation

Projects
None yet
1 participant
@kevinrobinson
Copy link
Contributor

kevinrobinson commented Jan 29, 2019

Who is this PR for?

SHS educators, students

What problem does this PR fix?

Builds on #2383 and #2382, since student self-reflections often include important insights about specific courses, but these aren't visible for educators looking at course grades.

What does this PR do?

Adds these insights into the part of the profile page showing course grades.

Screenshot (if adding a client-side feature)

screen shot 2019-01-29 at 3 48 46 pm

screen shot 2019-01-29 at 4 00 13 pm

Checklists

Which features or pages does this PR touch?

  • Student Profile

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Included specs for changes
  • Manual testing made more sense here

@kevinrobinson kevinrobinson force-pushed the feature/self-reflection-on-grades branch from 1dbce8b to 86c872c Jan 29, 2019

@kevinrobinson

This comment has been minimized.

Copy link
Contributor Author

kevinrobinson commented Jan 29, 2019

selfie

@kevinrobinson kevinrobinson merged commit 46e621b into master Jan 29, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@kevinrobinson kevinrobinson deleted the feature/self-reflection-on-grades branch Jan 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment