New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Student voice: Fix timezone bug on imports; release profile insights with feature switch for Q2 self-reflection #2387

Merged
merged 5 commits into from Jan 30, 2019

Conversation

Projects
None yet
1 participant
@kevinrobinson
Copy link
Contributor

kevinrobinson commented Jan 30, 2019

Building on #2382, #2381, #2383, #2384 and #2379.

Who is this PR for?

SHS educators, students

What problem does this PR fix?

There was a bug with importing timestamps from Sheets, so these timestamps were in the wrong timezone and then wouldn't be visible in the feed like they should be.

What does this PR do?

This reworks timestamp parsing for all survey importers, moving it into ImportMatcher and adding a test.

This also removes the ?winterinsights switch for profile insights, enabling it for all students and educators. It adds instead a PROFILE_INCLUDE_Q2_SELF_REFLECTION_INSIGHTS ENV switch for controlling whether the Q2 self-reflection is included, or whether it is just from "What I want my teachers to know about me."

Checklists

Which features or pages does this PR touch?

  • Home page
  • Student Profile

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Included specs for changes
  • Improved specs for existing code in need of better test coverage

@kevinrobinson kevinrobinson changed the title Patch/limited release student voice Student voice: Fix timezone bug on imports; release profile insights with feature switch for Q2 self-reflection Jan 30, 2019

@kevinrobinson

This comment has been minimized.

Copy link
Contributor Author

kevinrobinson commented Jan 30, 2019

selfie

@kevinrobinson kevinrobinson merged commit a191512 into master Jan 30, 2019

@kevinrobinson kevinrobinson deleted the patch/limited-release-student-voice branch Jan 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment