Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Session renewal: Fix bug from IE11 fetch polyfill #2389

Merged
merged 1 commit into from Jan 31, 2019

Conversation

@kevinrobinson
Copy link
Contributor

@kevinrobinson kevinrobinson commented Jan 31, 2019

The whatwg-fetch polyfill kicks in in IE11, and it doesn't support non-transparent redirection, or the redirected flag, since XmlHttpRequest follows redirects without any indication to the caller. So this changes to request JSON so the server responds with a 401 instead and avoids the issue.

This also updates the instrumentation, and makes a noop refactor to apiFetchJson to expose the plain method.

@kevinrobinson
Copy link
Contributor Author

@kevinrobinson kevinrobinson commented Jan 31, 2019

selfie

@kevinrobinson kevinrobinson merged commit d739d12 into master Jan 31, 2019
1 check was pending
1 check was pending
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@kevinrobinson kevinrobinson deleted the patch/session-renewal-ie-fetch branch Jan 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant