New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Student voice: Decouple profile insights and grades reflection switches #2392

Merged
merged 3 commits into from Feb 4, 2019

Conversation

Projects
None yet
1 participant
@kevinrobinson
Copy link
Contributor

kevinrobinson commented Feb 4, 2019

Fix bug between #2384 and #2387, where the feature switch controlling whether Q2 self-reflection appears in the "insights box" also would remove it from the grades tab. This decouples the two.

@kevinrobinson kevinrobinson changed the title Patch/decouple profile insights and grades reflection Student voice: Decouple profile insights and grades reflection switches Feb 4, 2019

@kevinrobinson

This comment has been minimized.

Copy link
Contributor Author

kevinrobinson commented Feb 4, 2019

selfie

@kevinrobinson kevinrobinson merged commit 7439148 into master Feb 4, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@kevinrobinson kevinrobinson deleted the patch/decouple-profile-insights-and-grades-reflection branch Feb 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment