New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance: Upgrade to React 16.7, add RollbarErrorBoundary #2397

Merged
merged 27 commits into from Feb 6, 2019

Conversation

Projects
None yet
1 participant
@kevinrobinson
Copy link
Contributor

kevinrobinson commented Feb 5, 2019

Who is this PR for?

developers, educators

What problem does this PR fix?

We don't have good visibility into certain kinds of errors within React components.

What does this PR do?

Upgrades React-related dependencies from 15.4 to 16.7. Adds RollbarErrorBoundary within <App />.

Also upgrades a bunch of libraries in the process (eg, babel versions).

Screenshot

error-boundary

Checklists

Which features or pages does this PR touch?

  • Core

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Included specs for changes
  • Manual testing made more sense here
@kevinrobinson

This comment has been minimized.

Copy link
Contributor Author

kevinrobinson commented Feb 5, 2019

This came up from #2398 and related.

kevinrobinson added some commits Feb 6, 2019

@kevinrobinson

This comment has been minimized.

Copy link
Contributor Author

kevinrobinson commented Feb 6, 2019

Okay, so this does a few other things now. Updates to Babel 7, to resolve problems with the Jest config that didn't surface locally but did in Travis. In the process of trying to understand why the Travis config was different, I made three changes to the build config.

First, I updated the build to split the JS and Ruby tests, and parallelize them across VMs. Second, I updated the way the build cache works for yarn. These speed things up a minute or two, but not much. I tried unsuccessfully to get Travis to cache Ruby gems, since those take 2.5min to install, but can't get this to work with bundler: true or with manually specifying the gems folder to cache. Punting that for now, but this change cuts the total build time down ~1-2min.

This also surfaced that the Travis env set a timezone different than in production, and so I updated tests to all run in UTC to match the production deployment. This updates specs that were written to run in America/New_York to be correct for UTC now.

@kevinrobinson

This comment has been minimized.

Copy link
Contributor Author

kevinrobinson commented Feb 6, 2019

selfie

@kevinrobinson kevinrobinson merged commit 94560d9 into master Feb 6, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@kevinrobinson kevinrobinson deleted the upgrade/react-15-5 branch Feb 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment