Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign in: Release new sign in page #2405

Merged
merged 18 commits into from Feb 27, 2019

Conversation

Projects
None yet
1 participant
@kevinrobinson
Copy link
Contributor

commented Feb 12, 2019

The current plan is to release this for the week of 2/18.

Who is this PR for?

educators

What does this PR do?

Uses new designs from @ciscomeneses that are more beautiful, make space for feeling more like each individual district, and simplify the multifactor flow. It also updates the login to remove full email addresses, and allow just usernames.

This updates specs, and in particular the JS and feature tests around sign in that relied on specifics of the previous multifactor flow or form elements.

Previewed to users in #2403.

Screenshot (if adding a client-side feature)

design

image

invalid login

image

browser validations

image

image

multifactor

image

Checklists

Which features or pages does this PR touch?

  • Sign in page

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Included specs for changes
  • Manual testing made more sense here
@kevinrobinson

This comment has been minimized.

Copy link
Contributor Author

commented Feb 27, 2019

selfie

@kevinrobinson kevinrobinson merged commit a25bb0a into master Feb 27, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@kevinrobinson kevinrobinson deleted the feature/sign-in-design-improvements branch Feb 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.