Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile: Remove second 'ago' suffix from testing tab to prevent overflow #2416

Merged
merged 1 commit into from
Feb 15, 2019

Conversation

kevinrobinson
Copy link
Contributor

Who is this PR for?

HS educators

What problem does this PR fix?

Overflow when separate test times for MCAS.

What does this PR do?

Fixes it by removing one of the "ago" suffixes.

Screenshot (if adding a client-side feature)

before

screen shot 2019-02-15 at 12 22 51 pm

after

screen shot 2019-02-15 at 12 23 15 pm

Checklists

Which features or pages does this PR touch?

  • Student Profile

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Included specs for changes
  • Manual testing made more sense here

@kevinrobinson
Copy link
Contributor Author

selfie

@kevinrobinson kevinrobinson merged commit ec9905e into master Feb 15, 2019
@kevinrobinson kevinrobinson deleted the patch/testing-ago-text branch February 15, 2019 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant