Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign in: Feedback while signing in, using rails-ujs #2425

Merged
merged 1 commit into from Mar 5, 2019

Conversation

Projects
None yet
1 participant
@kevinrobinson
Copy link
Contributor

commented Mar 5, 2019

Who is this PR for?

educators

What problem does this PR fix?

Limited visual feedback while waiting for sign-in to process.

What does this PR do?

Disables input elements, updates button text to show sign-in is in-progress. See https://github.com/rails/jquery-ujs/wiki/Unobtrusive-scripting-support-for-jQuery

Screenshot (if adding a client-side feature)

screen shot 2019-03-05 at 5 40 12 pm

Checklists

Which features or pages does this PR touch?

  • Sign in

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Manual testing made more sense here
@kevinrobinson

This comment has been minimized.

Copy link
Contributor Author

commented Mar 5, 2019

selfie

@kevinrobinson kevinrobinson merged commit c94153a into master Mar 5, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@kevinrobinson kevinrobinson deleted the patch/sign-in-feedback branch Mar 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.