Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Home page feed: Allow flag for showing photos #2432

Merged
merged 3 commits into from Mar 21, 2019

Conversation

Projects
None yet
1 participant
@kevinrobinson
Copy link
Contributor

commented Mar 21, 2019

Who is this PR for?

educators, students

What problem does this PR fix?

Most students have photos, but these aren't visible on the home page feed.

What does this PR do?

Adds photos in, with a querystring flag for now to support auditing. If there is no photo, falls back to showing nothing there (rather than placeholder).

Screenshot (if adding a client-side feature)

Screen Shot 2019-03-21 at 12 38 04 PM

Checklists

Which features or pages does this PR touch?

  • Home page
  • Student Profile

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Included specs for changes
  • Improved specs for existing code in need of better test coverage
  • Manual testing made more sense here
@kevinrobinson

This comment has been minimized.

Copy link
Contributor Author

commented Mar 21, 2019

selfie

@kevinrobinson kevinrobinson merged commit 903c817 into master Mar 21, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@kevinrobinson kevinrobinson deleted the feature/feed-student-photos branch Mar 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.