Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Photos: Update to use cropped on homeroom page, release on home page #2435

Merged
merged 11 commits into from Mar 26, 2019

Conversation

Projects
None yet
1 participant
@kevinrobinson
Copy link
Contributor

commented Mar 26, 2019

Who is this PR for?

educators

What does this PR do?

For the home page, #2432 was released behind a feature switch; this releases it for all.

On the homeroom page, this uses <StudentPhotoCropped /> so images have a fixed size, which prevents layout jump, while also compacting the table and showing a better view of the student's face.

Screenshot (if adding a client-side feature)

before

Screen Shot 2019-03-26 at 9 19 25 AM

after

Screen Shot 2019-03-25 at 4 47 09 PM

Checklists

Which features or pages does this PR touch?

  • Home page
  • Homeroom

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Included specs for changes
  • Manual testing made more sense here
@kevinrobinson

This comment has been minimized.

Copy link
Contributor Author

commented Mar 26, 2019

selfie

@kevinrobinson kevinrobinson merged commit 0b9b9f4 into master Mar 26, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@kevinrobinson kevinrobinson deleted the feature/homeroom-roster-photos-cropped branch Mar 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.