Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Photos: Update to use cropped on homeroom page, release on home page #2435

merged 11 commits into from
Mar 26, 2019


Copy link

Who is this PR for?


What does this PR do?

For the home page, #2432 was released behind a feature switch; this releases it for all.

On the homeroom page, this uses <StudentPhotoCropped /> so images have a fixed size, which prevents layout jump, while also compacting the table and showing a better view of the student's face.

Screenshot (if adding a client-side feature)


Screen Shot 2019-03-26 at 9 19 25 AM


Screen Shot 2019-03-25 at 4 47 09 PM


Which features or pages does this PR touch?

  • Home page
  • Homeroom

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Included specs for changes
  • Manual testing made more sense here

Copy link
Contributor Author


@kevinrobinson kevinrobinson merged commit 0b9b9f4 into master Mar 26, 2019
@kevinrobinson kevinrobinson deleted the feature/homeroom-roster-photos-cropped branch March 26, 2019 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

1 participant