Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Section, My Students: Add student photo, cropped small #2436

Merged
merged 14 commits into from Mar 26, 2019

Conversation

Projects
None yet
1 participant
@kevinrobinson
Copy link
Contributor

commented Mar 26, 2019

Who is this PR for?

HS educators

What problem does this PR fix?

No photos on section page.

What does this PR do?

Adds them, similar to #2435

Screenshot (if adding a client-side feature)

Screen Shot 2019-03-26 at 9 47 50 AM

Screen Shot 2019-03-26 at 10 03 37 AM

Checklists

Which features or pages does this PR touch?

  • Section
  • My Students

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Included specs for changes
@kevinrobinson

This comment has been minimized.

Copy link
Contributor Author

commented Mar 26, 2019

selfie

@kevinrobinson kevinrobinson merged commit 180e917 into master Mar 26, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@kevinrobinson kevinrobinson deleted the feature/section-cropped-photos branch Mar 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.