-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Profile: Update UX for creating and editing notes #2437
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ervice integration spec, add restricted DraftNote spec
kevinrobinson
changed the title
Remove use of nowMoment prop in TakeNotes
Profile: Update UX for creating and editing notes
Mar 26, 2019
selfie |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Who is this PR for?
educators
What problem does this PR fix?
This makes a set of changes related to writing notes. It's aimed at moving towards specific improvements related to autosaving, getting more information about permissions. And also aimed at unifying the UX and code for creating, editing and viewing.
What does this PR do?
For creating a note:
<FeedCardFrame />
as part of migrating the create/edit UX togetherUpdating a note:
Technical bits:
PageContainer
, properly tracking edits to each note, and simplifying some of the state change code. Ccallbacks related to transition notes (eg,saveTransitionNote
) are removed as well.EditableTextComponent
and theSanitize
code are removed, which used contentEditable and then some manual HTML sanitizing. This is just a plain<textarea />
now and all user input is escaped through React.ResizingTextArea
for editing.Next pieces, not in this PR:
<FeedCardFrame />
Screenshot (if adding a client-side feature)
There are many other cases, tested in
NoteCard.test.js
and visualized inNoteCard.story.js
.Create, links removed
Edit, revisions
Checklists
Which features or pages does this PR touch?
Does this PR use tests to help verify we can deploy these changes quickly and confidently?