Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layout: Update min-width on body, navbar sizing #2440

merged 2 commits into from Mar 29, 2019


Copy link

Who is this PR for?


What problem does this PR fix?

Two layout issues: horizontal scrollbars showing unnecessarily on 1024px wide IE11 browsers, and navbar width leading to text wrapping for particular users when many links.

What does this PR do?

Updates body min-width to match workaround JS function and removes that fn. Fixes the width of the searchbar to prevent jumping when font is initially loaded (there was a bug in the CSS before), and use placeholder instead of label to reduce its overall width while increasing size that's interactable.

Screenshot (if adding a client-side feature)

Screen Shot 2019-03-29 at 12 02 55 PM


Which features or pages does this PR touch?

  • Layout and navbar

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Manual testing made more sense here

Copy link
Contributor Author


@kevinrobinson kevinrobinson merged commit f209003 into master Mar 29, 2019
@kevinrobinson kevinrobinson deleted the patch/body-width branch March 29, 2019 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

1 participant