Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Class lists: Enable naming lists for other purposes (eg, science classes) #2444

Merged
merged 12 commits into from May 1, 2019

Conversation

Projects
None yet
1 participant
@kevinrobinson
Copy link
Contributor

commented May 1, 2019

Who is this PR for?

middle school teams

What problem does this PR fix?

Middle school teams also sometimes make different sets of class lists (eg, subject-specific classes like science, different sets of class lists for a dual-language program When folks did this last year, they'd make multiple class lists and describe them in the comments, but this wasn't visible in the class lists.

What does this PR do?

Moves this up front, and asks teams to name each list, with a default suggestion of "homerooms."

Screenshot (if adding a client-side feature)

Screen Shot 2019-05-01 at 9 40 34 AM

Screen Shot 2019-05-01 at 9 39 36 AM

Checklists

Which features or pages does this PR touch?

  • Class list view
  • Class list creator

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Included specs for changes
  • Manual testing made more sense here
@kevinrobinson

This comment has been minimized.

Copy link
Contributor Author

commented May 1, 2019

selfie

@kevinrobinson kevinrobinson merged commit 903fcfe into master May 1, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@kevinrobinson kevinrobinson deleted the feature/class-lists-list-type-text branch May 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.