Class lists: Add student photo to class list creator #2448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t-beautiful-dnd / snapshot renderer mismatch
|
selfie |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Who is this PR for?
K8 teaching teams
What problem does this PR fix?
Now with more human :)
What does this PR do?
Adds in student photos, and an icon if there's a recent note (within the last 45 days).
This also revealed a test bug with the way students were "consistently" hashed into buckets for stories and tests. This is changed to only look at the student id now, and this led to a bunch of trashing in tests and stories, and some misconfiguration between the react-test-renderer for snapshots and react-beautiful-dnd that I couldn't figure out, but probably came from #2447 and weren't until trying to add more kinds of snapshots to catch regressions that before were only visible in stories. There's some more tests here, but the root issue isn't resolve and is mostly worked around, with some comments added (eg,
Invariant failed: provided.innerRef has not been provided with a HTMLElement.).Screenshot (if adding a client-side feature)
Checklists
Which features or pages does this PR touch?
Does this PR use tests to help verify we can deploy these changes quickly and confidently?