Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Class lists: Add student photo to class list creator #2448
Who is this PR for?
K8 teaching teams
What problem does this PR fix?
Now with more human :)
What does this PR do?
Adds in student photos, and an icon if there's a recent note (within the last 45 days).
This also revealed a test bug with the way students were "consistently" hashed into buckets for stories and tests. This is changed to only look at the student id now, and this led to a bunch of trashing in tests and stories, and some misconfiguration between the react-test-renderer for snapshots and react-beautiful-dnd that I couldn't figure out, but probably came from #2447 and weren't until trying to add more kinds of snapshots to catch regressions that before were only visible in stories. There's some more tests here, but the root issue isn't resolve and is mostly worked around, with some comments added (eg,
Screenshot (if adding a client-side feature)
Which features or pages does this PR touch?
Does this PR use tests to help verify we can deploy these changes quickly and confidently?