Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Class lists: Add student photo to class list creator #2448

Merged
merged 13 commits into from May 2, 2019

Conversation

Projects
None yet
1 participant
@kevinrobinson
Copy link
Contributor

commented May 1, 2019

Who is this PR for?

K8 teaching teams

What problem does this PR fix?

Now with more human :)

What does this PR do?

Adds in student photos, and an icon if there's a recent note (within the last 45 days).

This also revealed a test bug with the way students were "consistently" hashed into buckets for stories and tests. This is changed to only look at the student id now, and this led to a bunch of trashing in tests and stories, and some misconfiguration between the react-test-renderer for snapshots and react-beautiful-dnd that I couldn't figure out, but probably came from #2447 and weren't until trying to add more kinds of snapshots to catch regressions that before were only visible in stories. There's some more tests here, but the root issue isn't resolve and is mostly worked around, with some comments added (eg, Invariant failed: provided.innerRef has not been provided with a HTMLElement.).

Screenshot (if adding a client-side feature)

Screen Shot 2019-05-01 at 11 26 33 AM

Checklists

Which features or pages does this PR touch?

  • Class lists

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Included specs for changes
  • Manual testing made more sense here
@kevinrobinson

This comment has been minimized.

Copy link
Contributor Author

commented May 2, 2019

selfie

@kevinrobinson kevinrobinson merged commit 8d04c59 into master May 2, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@kevinrobinson kevinrobinson deleted the patch/add-student-photo-to-class-list branch May 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.