Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Class lists: Use CleanSlateMessage and apply policy to notes within dialog #2453

Merged
merged 1 commit into from May 7, 2019

Conversation

Projects
None yet
1 participant
@kevinrobinson
Copy link
Contributor

commented May 7, 2019

Who is this PR for?

K8 teaching teams

What problem does this PR fix?

The <InlineStudentProfile /> shown within the class list maker doesn't apply the "clean slate" policy for notes, and shows historical notes further back than it should.

Also makes some UI tweaks for IE.

What does this PR do?

Refactors the filtering, and applies it to the class list dialog as well. Adjusts the width of notes column in the dialog, the "equity checks" sizing to work properly on IE11.

Screenshot (if adding a client-side feature)

Screen Shot 2019-05-07 at 8 55 49 AM

Checklists

Which features or pages does this PR touch?

  • Class lists
  • Student Profile

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Included specs for changes
  • Manual testing made more sense here
@kevinrobinson

This comment has been minimized.

Copy link
Contributor Author

commented May 7, 2019

selfie

@kevinrobinson kevinrobinson merged commit 8e9a470 into master May 7, 2019

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@kevinrobinson kevinrobinson deleted the feature/clean-slate-on-class-list-notes branch May 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.