Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Class list: Fix bug with branching on STAR/DIBELS in profile #2454

Conversation

Projects
None yet
1 participant
@kevinrobinson
Copy link
Contributor

commented May 7, 2019

Who is this PR for?

K8 teaching teams

What problem does this PR fix?

STAR data should only be shown for students going into grade 3 or later, but the branching in the inline profile wasn't correct since there was no grade field sent down on the student record.

What does this PR do?

Uses the gradeLevelNextYear to fix the branching.

Checklists

Which features or pages does this PR touch?

  • Class lists

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Included specs for changes
@kevinrobinson

This comment has been minimized.

Copy link
Contributor Author

commented May 7, 2019

selfie

@kevinrobinson kevinrobinson merged commit a41b9e6 into master May 7, 2019

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@kevinrobinson kevinrobinson deleted the patch/class-list-grade-level-reading-branching-in-profile branch May 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.