Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Class lists: Revise MegaReadingImporter for use with aggregate K and 1 reading data #2455

Merged
merged 3 commits into from May 7, 2019

Conversation

Projects
None yet
1 participant
@kevinrobinson
Copy link
Contributor

commented May 7, 2019

Who is this PR for?

K2 teaching teams

What problem does this PR fix?

Most recent F&P levels aren't yet imported for younger grades, for use in checks within class list maker tool.

What does this PR do?

  • move MegaReadingImporter to use FuzzyMatcher
  • fix FuzzyMatcher for multiple words in last names
  • updated MegaReadingImporter to use new column keys for K and 1
  • update validations on ReadingBenchmarkData to support new data point types

This doesn't update any controller or UI code yet.

Checklists

Which features or pages does this PR touch?

  • Class lists
  • Student Profile
  • Reading

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Manual testing made more sense here
@kevinrobinson

This comment has been minimized.

Copy link
Contributor Author

commented May 7, 2019

selfie

@kevinrobinson kevinrobinson merged commit 59bfa90 into master May 7, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@kevinrobinson kevinrobinson deleted the feature/mega-reading-importer-revisions branch May 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.