Skip to content

Class lists: Revise MegaReadingImporter for use with aggregate K and 1 reading data - #2455

Merged
kevinrobinson merged 3 commits into
masterfrom
feature/mega-reading-importer-revisions
May 7, 2019
Merged

Class lists: Revise MegaReadingImporter for use with aggregate K and 1 reading data#2455
kevinrobinson merged 3 commits into
masterfrom
feature/mega-reading-importer-revisions

Conversation

@kevinrobinson

Copy link
Copy Markdown
Contributor

Who is this PR for?

K2 teaching teams

What problem does this PR fix?

Most recent F&P levels aren't yet imported for younger grades, for use in checks within class list maker tool.

What does this PR do?

  • move MegaReadingImporter to use FuzzyMatcher
  • fix FuzzyMatcher for multiple words in last names
  • updated MegaReadingImporter to use new column keys for K and 1
  • update validations on ReadingBenchmarkData to support new data point types

This doesn't update any controller or UI code yet.

Checklists

Which features or pages does this PR touch?

  • Class lists
  • Student Profile
  • Reading

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Manual testing made more sense here

@kevinrobinson

Copy link
Copy Markdown
Contributor Author

selfie

@kevinrobinson
kevinrobinson merged commit 59bfa90 into master May 7, 2019
@kevinrobinson
kevinrobinson deleted the feature/mega-reading-importer-revisions branch May 7, 2019 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant