Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory: Start migrating searchbar JSON out of Educator model #2459

Merged

Conversation

Projects
None yet
1 participant
@kevinrobinson
Copy link
Contributor

commented May 8, 2019

Who is this PR for?

everyone

What problem does this PR fix?

There's a lot of data on the Educator model precomputed for the search bar that is otherwise never used when querying the Educator model. This means we're allocating lots of text we never need.

What does this PR do?

Starts the migration, adding EducatorSearchbar to hold this and updating the controller code to go through EducatorSearchbar. Deployment sequence:

first:

  • set USE_SEARCHBAR_JSON_ON_EDUCATOR_MODEL=true
  • deploy!
  • verify querying new endpoint
  • run rake task to write to new field
  • cut over to query from new field (remove USE_SEARCHBAR_JSON_ON_EDUCATOR_MODEL)

next PR (#2460):

  • remove old endpoint
  • remove old read and feature switch
  • remove column
  • remove old as_json optimization

Checklists

Which features or pages does this PR touch?

  • Core, search bar

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Included specs for changes
  • Improved specs for existing code in need of better test coverage
  • Manual testing made more sense here

kevinrobinson added some commits May 9, 2019

@kevinrobinson

This comment has been minimized.

Copy link
Contributor Author

commented May 9, 2019

selfie

@kevinrobinson kevinrobinson merged commit 51e6fdf into master May 9, 2019

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@kevinrobinson kevinrobinson deleted the feature/student-searchbar-split-from-educator-table branch May 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.