Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Class lists: Update list to be narrower with short school names and shorter dates #2462

Merged
merged 1 commit into from May 8, 2019

Conversation

@kevinrobinson
Copy link
Contributor

@kevinrobinson kevinrobinson commented May 8, 2019

Who is this PR for?

K8 admin

What problem does this PR fix?

With names and staff names, these can be a bit long and overflow 1024px wide. No one likes horizontal scrollbars :)

What does this PR do?

Add in short school names for Somerville, and cut date rendering from "Wednesday" to "Wed".

Screenshot (if adding a client-side feature)

Screen Shot 2019-05-08 at 4 19 17 PM

Checklists

Which features or pages does this PR touch?

  • Class lists view

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Included specs for changes
  • Manual testing made more sense here
@kevinrobinson
Copy link
Contributor Author

@kevinrobinson kevinrobinson commented May 8, 2019

selfie

@kevinrobinson kevinrobinson merged commit 7a22382 into master May 8, 2019
1 check was pending
@kevinrobinson kevinrobinson deleted the patch/class-lists-narrower branch May 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant