Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reading: Refactor to clarify importers, placeholder reading importer for Somerville #2468

Merged
merged 3 commits into from May 10, 2019

Conversation

@kevinrobinson
Copy link
Contributor

@kevinrobinson kevinrobinson commented May 10, 2019

Who is this PR for?

internal team, developers, working towards K8 teaching teams

What does this PR do?

"importer" files have different interfaces, so rename files to "processor" if they just take a file directly (eg, on the command line). This will help clarify as we automate more of this and use other transport methods (eg, Google API).

Also adds a placeholder SomervilleMegaReadingImporter file with comments for collaboration.

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Included specs for changes
@kevinrobinson
Copy link
Contributor Author

@kevinrobinson kevinrobinson commented May 10, 2019

selfie

@kevinrobinson kevinrobinson merged commit 72b6ab2 into master May 10, 2019
1 check was pending
@kevinrobinson kevinrobinson deleted the patch/reading-processor-placeholder-importer branch May 10, 2019
@@ -0,0 +1,67 @@
class SomervilleMegaReadingImporter
Copy link
Contributor Author

@kevinrobinson kevinrobinson May 10, 2019

@edavidsonsawyer I thought this might be helpful for talking more concretely about what it might look like to write a reading importer. This is placeholder for talking about that, with the idea that this might be able to combine parts of MegaReadingImporter with some kind of "Fetcher" class from #2442.

Copy link
Collaborator

@edavidsonsawyer edavidsonsawyer May 10, 2019

Nice! I've been changing around the import script to work more flexibly as a class with fewer opinions about what it's fetching. It should integrate well with these changes. If there's time on the call today we can talk that over quickly.

Copy link
Contributor Author

@kevinrobinson kevinrobinson May 10, 2019

awesome! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants