Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reading: Allow reviewing more assessments in /reading/debug #2472

Merged
merged 7 commits into from May 16, 2019

Conversation

Projects
None yet
1 participant
@kevinrobinson
Copy link
Contributor

commented May 16, 2019

Who is this PR for?

internal team

What problem does this PR fix?

More visibility into what has been imported, what can be rendered, distributions of data.

What does this PR do?

Allows looking at multiple benchmark assessments, supports "flipping" the table, and using box-and-whisker for some data points.

Adds more thresholds, factors those out into their own file.

Screenshot (if adding a client-side feature)

example:
Screen Shot 2019-05-16 at 5 19 32 PM

when selecting:
Screen Shot 2019-05-16 at 5 19 37 PM

Checklists

Which features or pages does this PR touch?

  • Reading debug

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Included specs for changes
  • Manual testing made more sense here
@kevinrobinson

This comment has been minimized.

Copy link
Contributor Author

commented May 16, 2019

selfie

@kevinrobinson kevinrobinson merged commit e21ee72 into master May 16, 2019

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@kevinrobinson kevinrobinson deleted the feature/reading-data-migrations branch May 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.