Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Counselor Meetings: Add initial version for feedback and testing #2477

Merged
merged 28 commits into from May 24, 2019

Conversation

Projects
None yet
1 participant
@kevinrobinson
Copy link
Contributor

commented May 24, 2019

Who is this PR for?

SHS counseling team

What problem does this PR fix?

A page for counselors to students they haven't connected with in a while, especially in situations with large caseloads.

What does this PR do?

Adds a new page at /counselors/meetings.

This is based on the awesome design and UX work by @ciscomeneses and @amyo423 in https://docs.google.com/presentation/d/1_uhHiq2j_gr0_Uu0tf1meSU27Z0lnjTjgMV3bgzwKkY/edit#slide=id.g55fc9767bc_0_11, and their awesome engineering work building most of this as well 馃憤 馃敟

There's no link visible yet, and this is behind a feature switch.

Checklists

Which features or pages does this PR touch?

  • Counselor meetings

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Included specs for changes
  • Manual testing made more sense here
@kevinrobinson

This comment has been minimized.

Copy link
Contributor Author

commented May 24, 2019

selfie

@kevinrobinson kevinrobinson merged commit f8df9d9 into master May 24, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@kevinrobinson kevinrobinson deleted the feature/counselor-meeting-page-merged branch May 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.