Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transition Notes: Add dialog for transition notes, refactoring for my notes, migrations for previous #2480

Merged
merged 51 commits into from May 26, 2019

Conversation

Projects
None yet
1 participant
@kevinrobinson
Copy link
Contributor

commented May 26, 2019

Who is this PR for?

8th grade and 9th grade SPS counseling team

What problem does this PR fix?

Helping counselors with handoffs across 8th and 8th grade.

What does this PR do?

The My Notes page had code tangled into the NotesList and NoteCard components that made it more challenging to refactor them for supporting a new kind of note on the profile. This PR factors out NoteShell for the profile frame, adds in substanceOnly to NoteCard so that it can be framed in different ways. This allows removing the code related to the My Notes page from these components. In the process, it reworks the My Notes page to use FeedCardFrame as a step away from using the profile code in different ways.

Screen Shot 2019-05-26 at 4 58 43 PM

I also adds "second transition note" model, controller, and UI elements for showing them inline on the profile page, and for 8th grade counselors to write them. This is controlled by a few existing permissions, and a new one called enable_transition_note_features.

Screen Shot 2019-05-26 at 5 00 50 PM

Screen Shot 2019-05-26 at 5 00 41 PM

Checklists

Which features or pages does this PR touch?

  • Student Profile
  • My Notes

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Included specs for changes
  • Improved specs for existing code in need of better test coverage
  • Manual testing made more sense here
@kevinrobinson

This comment has been minimized.

Copy link
Contributor Author

commented May 26, 2019

selfie

@kevinrobinson kevinrobinson merged commit bd04b5e into master May 26, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@kevinrobinson kevinrobinson deleted the feature/transition-note-designs branch May 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.