Transition Notes: Add dialog for transition notes, refactoring for my notes, migrations for previous#2480
Merged
Merged
Conversation
…sage 'Warning: Cannot update during an existing state transition (such as within ).
… fixture, including insights for older transition note
Contributor
Author
|
selfie |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Who is this PR for?
8th grade and 9th grade SPS counseling team
What problem does this PR fix?
Helping counselors with handoffs across 8th and 8th grade.
What does this PR do?
The My Notes page had code tangled into the
NotesListandNoteCardcomponents that made it more challenging to refactor them for supporting a new kind of note on the profile. This PR factors outNoteShellfor the profile frame, adds insubstanceOnlytoNoteCardso that it can be framed in different ways. This allows removing the code related to the My Notes page from these components. In the process, it reworks the My Notes page to useFeedCardFrameas a step away from using the profile code in different ways.I also adds "second transition note" model, controller, and UI elements for showing them inline on the profile page, and for 8th grade counselors to write them. This is controlled by a few existing permissions, and a new one called
enable_transition_note_features.Checklists
Which features or pages does this PR touch?
Does this PR use tests to help verify we can deploy these changes quickly and confidently?