Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transition notes: Simplified inline read path, refactoring RestrictedNotePresence #2482

merged 2 commits into from May 28, 2019


Copy link

Who is this PR for?

9th grade counselors

What problem does this PR fix?

The dialog view for editing and viewing transition notes is more complex, and the inline view didn't let them read restricted information.

What does this PR do?

Refactors <RestrictedNotePresence /> to use it inline for reading transition notes.

Screenshot (if adding a client-side feature)

Screen Shot 2019-05-28 at 10 14 26 AM

Screen Shot 2019-05-28 at 10 14 38 AM


Which features or pages does this PR touch?

  • Student Profile
  • My notes

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Included specs for changes
  • Manual testing made more sense here

Copy link
Contributor Author


@kevinrobinson kevinrobinson merged commit 709ee2a into master May 28, 2019
@kevinrobinson kevinrobinson deleted the feature/read-restricted branch May 28, 2019 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

1 participant