Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transition notes: Show new transition inline in profile list after saving #2483

Merged
merged 4 commits into from May 28, 2019

Conversation

Projects
None yet
1 participant
@kevinrobinson
Copy link
Contributor

commented May 28, 2019

Who is this PR for?

8th grade counselors

What problem does this PR fix?

New transition notes don't appear inline, so it's not clear that they are saved.

What does this PR do?

Fixes that, updating the UI on confirmed save. This punts on editing inline still.

Checklists

Which features or pages does this PR touch?

  • Student Profile

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Manual testing made more sense here
@kevinrobinson

This comment has been minimized.

Copy link
Contributor Author

commented May 28, 2019

selfie

@kevinrobinson kevinrobinson merged commit e8d6bec into master May 28, 2019

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@kevinrobinson kevinrobinson deleted the patch/transition-note-show-inline branch May 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.