Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Searchbar: Mitigations for searching through many students #2484

Merged
merged 3 commits into from May 28, 2019

Conversation

Projects
None yet
1 participant
@kevinrobinson
Copy link
Contributor

commented May 28, 2019

Who is this PR for?

districtwide admin

What problem does this PR fix?

Autocomplete freezes for a bit with ~10k students.

What does this PR do?

Mitigates it by adding a min-length, delaying the responsiveness, and adding a CSS scroll overflow. The real problem is rendering so many items in the list, but jQuery UI hooks don't let us simply change that. #2194 is the better path beyond short-term mitigations.

Checklists

Which features or pages does this PR touch?

  • Core

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Manual testing made more sense here
@kevinrobinson

This comment has been minimized.

Copy link
Contributor Author

commented May 28, 2019

selfie

@kevinrobinson kevinrobinson merged commit 3fca04d into master May 28, 2019

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@kevinrobinson kevinrobinson deleted the patch/searchbar-too-many branch May 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.