Searchbar: Mitigations for searching through many students#2484
Merged
kevinrobinson merged 3 commits intomasterfrom May 28, 2019
Merged
Searchbar: Mitigations for searching through many students#2484kevinrobinson merged 3 commits intomasterfrom
kevinrobinson merged 3 commits intomasterfrom
Conversation
Contributor
Author
|
selfie |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Who is this PR for?
districtwide admin
What problem does this PR fix?
Autocomplete freezes for a bit with ~10k students.
What does this PR do?
Mitigates it by adding a min-length, delaying the responsiveness, and adding a CSS scroll overflow. The real problem is rendering so many items in the list, but jQuery UI hooks don't let us simply change that. #2194 is the better path beyond short-term mitigations.
Checklists
Which features or pages does this PR touch?
Does this PR use tests to help verify we can deploy these changes quickly and confidently?