Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double revert for Student searchbar: Migrate to React component and optimize for larger lists #2487

Merged

Conversation

Projects
None yet
1 participant
@kevinrobinson
Copy link
Contributor

commented May 29, 2019

Double revert with a patch. Original PR was #2485, revert was #2486.

This patches the issue in IE11, which led to the contents of the page being blank, since the error was in index.js. The problem was that document.querySelectorAll(selector).forEach isn't supported in IE11. This adds a polyfill, and I verified manually that this fixes the issue locally.

Patch is commit on top, 0623c26.

kevinrobinson added some commits May 29, 2019

@kevinrobinson

This comment has been minimized.

Copy link
Contributor Author

commented May 29, 2019

selfie

@kevinrobinson kevinrobinson merged commit 70ae56c into master May 29, 2019

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@kevinrobinson kevinrobinson deleted the revert-2486-revert-2485-feature/search-students-rebase branch May 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.