Double revert for Student searchbar: Migrate to React component and optimize for larger lists #2487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…imize for larger lists ""
Contributor
Author
|
selfie |
kevinrobinson
deleted the
revert-2486-revert-2485-feature/search-students-rebase
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Double revert with a patch. Original PR was #2485, revert was #2486.
This patches the issue in IE11, which led to the contents of the page being blank, since the error was in
index.js. The problem was thatdocument.querySelectorAll(selector).forEachisn't supported in IE11. This adds a polyfill, and I verified manually that this fixes the issue locally.Patch is commit on top, 0623c26.