Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bedford transition: Initial processor code, prototype read path for notes and insight box #2488

Merged
merged 9 commits into from May 31, 2019

Conversation

Projects
None yet
1 participant
@kevinrobinson
Copy link
Contributor

commented May 30, 2019

Who is this PR for?

Bedford teachers

What problem does this PR fix?

This is aimed at handoffs across years and schools in Bedford.

What does this PR do?

Folks wrote transition information in some sheets, and this includes code for processing them, and initial code for viewing that information on the profile page (in notes, and in insight box, not in services yet). The import isn't automated.

This also refactors some UI code related to the insights box, and the last commit includes renaming of all insights JS files and profile_insights as well.

Screenshot (if adding a client-side feature)

Screen Shot 2019-05-30 at 6 21 22 PM

Screen Shot 2019-05-30 at 6 21 18 PM

Screen Shot 2019-05-30 at 6 10 13 PM

Checklists

Which features or pages does this PR touch?

  • Student Profile

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Included specs for changes
  • Improved specs for existing code in need of better test coverage
  • Manual testing made more sense here
@kevinrobinson

This comment has been minimized.

Copy link
Contributor Author

commented May 31, 2019

selfie

@kevinrobinson kevinrobinson merged commit 5e59f39 into master May 31, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@kevinrobinson kevinrobinson deleted the feature/bedford-transition-import branch May 31, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.