Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transitions: Update filters for transitions page #2491

merged 4 commits into from Jun 1, 2019


Copy link

@kevinrobinson kevinrobinson commented Jun 1, 2019

Who is this PR for?

8th grade counselors, 9th grade counselors and assistant principals

What problem does this PR fix?

Folks can sort and search, but not obvious filter for starred / has a note / school.

What does this PR do?

Adds them. Also updates default sort to "Starred for discussion?" and adjust the column widths.


Which features or pages does this PR touch?

  • Transitions

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Included specs for changes
  • Improved specs for existing code in need of better test coverage
  • Manual testing made more sense here
Copy link
Contributor Author

@kevinrobinson kevinrobinson commented Jun 1, 2019


@kevinrobinson kevinrobinson merged commit 66bf435 into master Jun 1, 2019
1 check passed
@kevinrobinson kevinrobinson deleted the feature/transition-note-filters branch Jun 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant