Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reader profile: months ago, multiple chips for services #2500

Merged
merged 1 commit into from Jun 7, 2019

Conversation

Projects
None yet
1 participant
@kevinrobinson
Copy link
Contributor

commented Jun 7, 2019

Who is this PR for?

K3 educators

What problem does this PR fix?

What does this PR do?

Split out multiple iterations of the same kind of service (eg, reading intervention group), show them as multiple chips.

Update the time context in services to be months ago, or days if recent. Add tooltip.

This needs another pass to consolidate the "time ago" math; this is just making it more usable for critique sessions today.

Screenshot (if adding a client-side feature)

Screen Shot 2019-06-07 at 11 32 21 AM

Checklists

Which features or pages does this PR touch?

  • Reader profile

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Included specs for changes
  • Manual testing made more sense here
@kevinrobinson

This comment has been minimized.

Copy link
Contributor Author

commented Jun 7, 2019

selfie

@kevinrobinson kevinrobinson merged commit d468143 into master Jun 7, 2019

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@kevinrobinson kevinrobinson deleted the patch/reading-services-months-ago branch Jun 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.