Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

District admin: Export 'wide' students spreadsheet #2507

Merged
merged 7 commits into from Jun 27, 2019

Conversation

Projects
None yet
1 participant
@kevinrobinson
Copy link
Contributor

commented Jun 27, 2019

Who is this PR for?

district admin

What problem does this PR fix?

district admin doing other kinds of rostering for summer school that want to be able to work from data within Student Insights, but permission and authorization is different and idiosyncratic for different summer school programs

What does this PR do?

Adds a districtwide export link for exporting a "wide" CSV with columns of data about students. This isn't all data, but a good baseline for one-off rostering cases like this that aren't common or important enough to support directly.

Screenshot (if adding a client-side feature)

Screen Shot 2019-06-27 at 9 59 45 AM

Checklists

Which features or pages does this PR touch?

  • School Overview
  • District admin

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Included specs for changes
  • Manual testing made more sense here
@kevinrobinson

This comment has been minimized.

Copy link
Contributor Author

commented Jun 27, 2019

This bundles commits for fixing Ruby whitespace issues that were sitting on master.

In response to looking at a security vulnerability report in eslint, it turns out that the vulnerability is very low risk for the project. Since we were a bit behind here, I decided to update eslint and related packages anyway, including updating code and tests to conform to new whitespace and special character rules.

@kevinrobinson kevinrobinson merged commit c92d4c7 into master Jun 27, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@kevinrobinson kevinrobinson deleted the feature/wide-export branch Jun 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.