Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security: Send security alert email to educator on potentially suspicious login #2508

Merged
merged 3 commits into from Jun 27, 2019

Conversation

@kevinrobinson
Copy link
Contributor

@kevinrobinson kevinrobinson commented Jun 27, 2019

Who is this PR for?

students, families

What does this PR do?

Adds a layer of defense for detecting unauthorized account access. Updates developer alerts to be Rollbar errors for realtime notifications, and adds notification emails to the educator of the impacted account. Note that these are all rough heuristics, but after a few months they have triggered a small percentage of false positives.

Checklists

Which features or pages does this PR touch?

  • Login

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Included specs for changes
  • Improved specs for existing code in need of better test coverage
@kevinrobinson
Copy link
Contributor Author

@kevinrobinson kevinrobinson commented Jun 27, 2019

selfie

@kevinrobinson kevinrobinson merged commit e472643 into master Jun 27, 2019
1 check failed
@kevinrobinson kevinrobinson deleted the feature/login-checker-notify-educator branch Jun 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant