Import: Add DataFlow descriptions to importer classes, with tests, for making visible in UI#2511
Merged
kevinrobinson merged 1 commit intomasterfrom Jun 28, 2019
Merged
Conversation
Contributor
Author
|
selfie |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Who is this PR for?
project leads
What problem does this PR fix?
The log of import tasks is somewhat visible, but it's more intended for developers. There's no way for district project leads to see importers directly, particularly for other kinds of imports that are semi-automated, or from different sources other than regular SIS syncs.
What does this PR do?
Adds some minimal description in code of what these are, intended to be put in a UI for users, alongside other kinds of data flows not yet visible (eg, student voice, reading data, transitions).
I'm mot sure doing this in code over docs adds real value, but trying it out for now.
Checklists
Which features or pages does this PR touch?
Does this PR use tests to help verify we can deploy these changes quickly and confidently?