Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import: Add DataFlow descriptions to importer classes, with tests, for making visible in UI #2511

Merged
merged 1 commit into from Jun 28, 2019

Conversation

Projects
None yet
1 participant
@kevinrobinson
Copy link
Contributor

commented Jun 28, 2019

Who is this PR for?

project leads

What problem does this PR fix?

The log of import tasks is somewhat visible, but it's more intended for developers. There's no way for district project leads to see importers directly, particularly for other kinds of imports that are semi-automated, or from different sources other than regular SIS syncs.

What does this PR do?

Adds some minimal description in code of what these are, intended to be put in a UI for users, alongside other kinds of data flows not yet visible (eg, student voice, reading data, transitions).

I'm mot sure doing this in code over docs adds real value, but trying it out for now.

Checklists

Which features or pages does this PR touch?

  • Imports

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Included specs for changes
@kevinrobinson

This comment has been minimized.

Copy link
Contributor Author

commented Jun 28, 2019

selfie

@kevinrobinson kevinrobinson merged commit b137f06 into master Jun 28, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@kevinrobinson kevinrobinson deleted the feature/importer-data-flows branch Jun 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.