Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search: Allow web search syntax when searching notes #2521

Merged
merged 11 commits into from Jul 16, 2019

Conversation

@kevinrobinson
Copy link
Contributor

kevinrobinson commented Jul 16, 2019

Who is this PR for?

educators

What does this PR do?

Supports typical search syntax like +/- and quoted phrases.

Checklists

Which features or pages does this PR touch?

  • Search notes

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Manual testing made more sense here
@kevinrobinson

This comment has been minimized.

Copy link
Contributor Author

kevinrobinson commented Jul 16, 2019

Also bundles some patches in response to low-risk advisories (see https://travis-ci.org/studentinsights/studentinsights/jobs/559507348), and a bunch of different workarounds for Travis to upgrade Postgres.

@kevinrobinson kevinrobinson merged commit 3d1c178 into master Jul 16, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@kevinrobinson kevinrobinson deleted the feature/use-web-search-for-notes branch Jul 16, 2019
@kevinrobinson

This comment has been minimized.

Copy link
Contributor Author

kevinrobinson commented Jul 16, 2019

FWIW, upgrading Postgres with Homebrew:

$ brew upgrade postgresql@11

Next, I quit Postgres using the little elephant menu in the task bar at the top of the screen.

After, I also followed the helpful Homebrew instructions about how to migrate existing databases:

$ brew services start postgresql

And rebuilt the local databases anyway:

$ bin/rails db:environment:set db:drop db:create db:migrate db:seed RAILS_ENV=development

Then ran a test to verify it worked:

$  bundle exec rspec spec/lib/search_notes_queries_spec.rb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.