Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monitoring: Rollbar functions can't be called without explicitly setting 'this' #2524

Merged
merged 1 commit into from Jul 18, 2019

Conversation

@kevinrobinson
Copy link
Contributor

kevinrobinson commented Jul 18, 2019

What problem does this PR fix?

Rollbar reporting in RollbarErrorBoundary wasn't working because our code assigned the reporting function to a variable without binding 'this'. This led to the Rollbar library code throwing and dropping the errors. 馃懀 馃敨

What does this PR do?

Removes use of variable.

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Manual testing made more sense here
@kevinrobinson

This comment has been minimized.

Copy link
Contributor Author

kevinrobinson commented Jul 18, 2019

selfie

@kevinrobinson kevinrobinson merged commit 618a74e into master Jul 18, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@kevinrobinson kevinrobinson deleted the patch/rollbar-reporting-call branch Jul 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can鈥檛 perform that action at this time.