Skip to content

Service: Add Bedford service types, part2#2537

Merged
kevinrobinson merged 11 commits into
masterfrom
migration/bedford-service-types
Aug 16, 2019
Merged

Service: Add Bedford service types, part2#2537
kevinrobinson merged 11 commits into
masterfrom
migration/bedford-service-types

Conversation

@kevinrobinson

@kevinrobinson kevinrobinson commented Jul 30, 2019

Copy link
Copy Markdown
Contributor

Migration step 2 for #2535, split out to isolate test changes.

Next is #2536.

@kevinrobinson

Copy link
Copy Markdown
Contributor Author

hmm, can't make sense of this: https://travis-ci.org/studentinsights/studentinsights/jobs/565628102#L3137

Screen Shot 2019-07-30 at 2 57 22 PM

It seems the migration is silently failing, and just isn't doing what it says it's doing ❓ 😕

@kevinrobinson

kevinrobinson commented Jul 30, 2019

Copy link
Copy Markdown
Contributor Author

k, .column_names is cached, and the cache is on that model's class so explicitly clearing that with ServiceType.reset_column_information now.

@kevinrobinson

kevinrobinson commented Jul 30, 2019

Copy link
Copy Markdown
Contributor Author

huh today I learned table structure is cached across migration files, never would have expected that and don't understand how migrations ever work at all then but not going to dig further now :) References:

And splitting it into separately PRs or commits doesn't resolve the issue either, since all migrations run at once in a clean Travis environment anyway. Still not sure why this didn't reproduce locally though; I thought I had dropped and re-run all migrations. Either way, shipping this and moving on.

@kevinrobinson

Copy link
Copy Markdown
Contributor Author

selfie

@kevinrobinson
kevinrobinson merged commit 3204219 into master Aug 16, 2019
@kevinrobinson
kevinrobinson deleted the migration/bedford-service-types branch August 16, 2019 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant