Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service: Add Bedford service types, part2 #2537

Merged
merged 11 commits into from Aug 16, 2019

Conversation

@kevinrobinson
Copy link
Contributor

kevinrobinson commented Jul 30, 2019

Migration step 2 for #2535, split out to isolate test changes.

Next is #2536.

@kevinrobinson

This comment has been minimized.

Copy link
Contributor Author

kevinrobinson commented Jul 30, 2019

hmm, can't make sense of this: https://travis-ci.org/studentinsights/studentinsights/jobs/565628102#L3137

Screen Shot 2019-07-30 at 2 57 22 PM

It seems the migration is silently failing, and just isn't doing what it says it's doing 😕

@kevinrobinson

This comment has been minimized.

Copy link
Contributor Author

kevinrobinson commented Jul 30, 2019

k, .column_names is cached, and the cache is on that model's class so explicitly clearing that with ServiceType.reset_column_information now.

@kevinrobinson

This comment has been minimized.

Copy link
Contributor Author

kevinrobinson commented Jul 30, 2019

huh today I learned table structure is cached across migration files, never would have expected that and don't understand how migrations ever work at all then but not going to dig further now :) References:

And splitting it into separately PRs or commits doesn't resolve the issue either, since all migrations run at once in a clean Travis environment anyway. Still not sure why this didn't reproduce locally though; I thought I had dropped and re-run all migrations. Either way, shipping this and moving on.

@kevinrobinson

This comment has been minimized.

Copy link
Contributor Author

kevinrobinson commented Aug 16, 2019

selfie

@kevinrobinson kevinrobinson merged commit 3204219 into master Aug 16, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@kevinrobinson kevinrobinson deleted the migration/bedford-service-types branch Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.