Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Teacher transition notes: Add importer and processor for Bedford school transition #2543

Merged
merged 13 commits into from Sep 6, 2019

Conversation

@kevinrobinson
Copy link
Contributor

kevinrobinson commented Aug 20, 2019

This is also a pass over all things related to transitions for Bedford. Various notes are below, but the core here is BedfordDavisSocialEmotionalImporter and BedfordDavisServicesImporter.

Remove form source' link from UI:

  • Remove "source" link in UI for BedfordTransitionSubstanceForProfile.js
  • Remove serializing form_url in profile_controller, add defensive spec.
  • Add defensive specs for ImportedForm#as_flattened_form not exposing form_url

Templates:

  • Move form_to_notes to templates folder
  • Add links to template sheets
  • Update FormsToNotesProcessor spec to include recorded_at timestamp

Importers and Processors:

  • Add warnings about deprecations for relevant notes (migration plan captured elsewhere)
  • Add specs on data_flow descriptions for importers not included in core import task
  • Update stats on invalid matches for tab names to educators
  • Add some other specs for importers, and some specs on deprecations
@kevinrobinson

This comment has been minimized.

Copy link
Contributor Author

kevinrobinson commented Sep 6, 2019

selfie

@kevinrobinson kevinrobinson merged commit 1b186f2 into master Sep 6, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@kevinrobinson kevinrobinson deleted the patch/comments-for-transition-processors branch Sep 6, 2019
@kevinrobinson kevinrobinson mentioned this pull request Sep 6, 2019
2 of 2 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.