Reading: Update MegaReadingImporter to 8/20/19 template format #2544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kevinrobinson this is great! I'll merge this into the other branch and we can focus on the importer there. |
…g-processor-new-template
|
Added some commits updating the UI debug tool (use Also fixed some bugs in the processor code (some bugs in the keys matching the import templates, periods not matching the import column keys). |
|
selfie cc @edavidsonsawyer |
3 tasks
kevinrobinson
deleted the
feature/mega-reading-processor-new-template
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #2523.
Who is this PR for?
Elementary teachers, reading specialists and district staff in Somerville
What problem does this PR fix?
Updates
MegaReadingImporterto work with the 8/20/19 template format, with tests. This will enable using this manually for some historical spring data that was entered in a slightly different format, and merges this in for use as part of automated imports in September more generally.What does this PR do?
Builds on @edavidsonsawyer's awesome work in #2523, taking
MegaReadingProcessorand the related fixture and spec. It adds a few small changes to tracking and how headers are handled, and adds some comments as well.@edavidsonsawyer This addresses some of the comments in #2523, so I think a step forward there is to merge this into that branch, and then work forward on the importer that makes use of this on a folder. I'm happy to chat more over on that issue or over email.
Peeling this off and merging it in so we can get some historical data imported now, and then we can finish off the importer component separately, since that won't be needed for another few weeks.
Checklists
Does this PR use tests to help verify we can deploy these changes quickly and confidently?