Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reading: Update MegaReadingImporter to 8/20/19 template format #2544

merged 15 commits into from Sep 11, 2019


Copy link

kevinrobinson commented Aug 21, 2019

Part of #2523.

Who is this PR for?

Elementary teachers, reading specialists and district staff in Somerville

What problem does this PR fix?

Updates MegaReadingImporter to work with the 8/20/19 template format, with tests. This will enable using this manually for some historical spring data that was entered in a slightly different format, and merges this in for use as part of automated imports in September more generally.

What does this PR do?

Builds on @edavidsonsawyer's awesome work in #2523, taking MegaReadingProcessor and the related fixture and spec. It adds a few small changes to tracking and how headers are handled, and adds some comments as well.

@edavidsonsawyer This addresses some of the comments in #2523, so I think a step forward there is to merge this into that branch, and then work forward on the importer that makes use of this on a folder. I'm happy to chat more over on that issue or over email.

Peeling this off and merging it in so we can get some historical data imported now, and then we can finish off the importer component separately, since that won't be needed for another few weeks.


Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Included specs for changes
  • Manual testing made more sense here

This comment has been minimized.

Copy link

edavidsonsawyer commented Aug 22, 2019

@kevinrobinson this is great! I'll merge this into the other branch and we can focus on the importer there.


This comment has been minimized.

Copy link
Contributor Author

kevinrobinson commented Sep 11, 2019

Added some commits updating the UI debug tool (use gradeThen when determining benchmark thresholds, including coverage of active students, related specs).

Also fixed some bugs in the processor code (some bugs in the keys matching the import templates, periods not matching the import column keys).


This comment has been minimized.

Copy link
Contributor Author

kevinrobinson commented Sep 11, 2019

selfie cc @edavidsonsawyer

@kevinrobinson kevinrobinson mentioned this pull request Sep 11, 2019
3 of 3 tasks complete
@kevinrobinson kevinrobinson merged commit 34528c5 into master Sep 11, 2019
1 check was pending
1 check was pending
continuous-integration/travis-ci/pr The Travis CI build is in progress
@kevinrobinson kevinrobinson deleted the feature/mega-reading-processor-new-template branch Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
2 participants
You can’t perform that action at this time.