Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upProject lead tools: Optimize district homerooms, improve layout on permissions pages #2545
Conversation
This comment has been minimized.
This comment has been minimized.
|
selfie |
kevinrobinson
merged commit d9c0524
into
master
1 check was pending
1 check was pending
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
kevinrobinson commentedAug 22, 2019
•
edited
Who is this PR for?
district project leads
What does this PR do?
District homeroom pages load slowly for some, this optimizes it and supports falling back if short school names aren't provided.
It also updates the layout of the permissions pages to be a bit clearer, and removes some older metrics on sign ins from permissions. These were only ever used internally on the team for debugging issues, and have been replaced by better internal tools. These project lead features are about permissions, not monitoring.
Screenshot (if adding a client-side feature)
adjust permissions
permissions overview
project lead links order
Checklists
Which features or pages does this PR touch?
Does this PR use tests to help verify we can deploy these changes quickly and confidently?