Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project lead tools: Optimize district homerooms, improve layout on permissions pages #2545

Merged
merged 4 commits into from Aug 22, 2019

Conversation

@kevinrobinson
Copy link
Contributor

kevinrobinson commented Aug 22, 2019

Who is this PR for?

district project leads

What does this PR do?

District homeroom pages load slowly for some, this optimizes it and supports falling back if short school names aren't provided.

It also updates the layout of the permissions pages to be a bit clearer, and removes some older metrics on sign ins from permissions. These were only ever used internally on the team for debugging issues, and have been replaced by better internal tools. These project lead features are about permissions, not monitoring.

Screenshot (if adding a client-side feature)

adjust permissions

image

permissions overview

Screen Shot 2019-08-22 at 9 43 31 AM

project lead links order

Screen Shot 2019-08-22 at 9 45 42 AM

Checklists

Which features or pages does this PR touch?

  • District homeroom overview
  • Permissions overview
  • Adjust permissions

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Included specs for changes
  • Manual testing made more sense here
@kevinrobinson

This comment has been minimized.

Copy link
Contributor Author

kevinrobinson commented Aug 22, 2019

selfie

@kevinrobinson kevinrobinson merged commit d9c0524 into master Aug 22, 2019
1 check was pending
1 check was pending
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@kevinrobinson kevinrobinson deleted the patch/enrollment-by-homerooms branch Aug 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.