Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Educators import: Mark `missing_from_last_export` and show project leads in permissions tools #2546
Who is this PR for?
Project leads across districts
What problem does this PR fix?
Typically project leads or district IT staff remove educators from the authentication system (eg, LDAP), which means they are not allowed to use Student Insights at all, regardless of past permissions.
By design, the district LDAP system controls who has access regardless of any data within Student Insights. But Student Insights stores records for staff and students after they have been removed from the daily export, so that it can maintain past information (eg, who wrote a note about a student).
For educator records, this distinction isn't tracked or shown. One of the project leads asked about it for an older staff. They understandably were concerned that seeing their name meant that person still had access.
What does this PR do?
Updates the importer and educator model to track this with
Uses this info in permissions tools for project leads so this process is visible for them. Removes some old cruft from the administrate config.
This PR doesn't update the authentication process, but a separate one will add a defensive layer beyond the district's own authentication check that ensures the educator record was still present in the latest SIS export.
Screenshot (if adding a client-side feature)
with the full blinding beauty of adminstrate forms :)
adjust permissions list
Which features or pages does this PR touch?
Does this PR use tests to help verify we can deploy these changes quickly and confidently?