Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Section exports: Update Somerville section exports to query for school year #2550

Merged
merged 1 commit into from Aug 26, 2019

Conversation

@kevinrobinson
Copy link
Contributor

kevinrobinson commented Aug 26, 2019

Who is this PR for?

Somerville IT pals

What problem does this PR fix?

These scripts required IT folks to update the school year in each one, and if one is missed then the import processes can't process the incomplete data.

What does this PR do?

With help from JB, these are now updated to query the master schedule for the current school year. (note the the "district_school_year" convention here is unchanged, and remains different from the Student Insights numbering in school_year.rb).

Checklists

Which features or pages does this PR touch?

  • SHS section importers

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Manual testing made more sense here
@kevinrobinson

This comment has been minimized.

Copy link
Contributor Author

kevinrobinson commented Aug 26, 2019

selfie, over email with JB

@kevinrobinson kevinrobinson merged commit 3329d3d into master Aug 26, 2019
1 check was pending
1 check was pending
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@kevinrobinson kevinrobinson deleted the patch/courses-export-school-year-dynamic branch Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.