Transition notes: Add more specs for reading restricted notes, update…#2565
Merged
kevinrobinson merged 1 commit intomasterfrom Aug 28, 2019
Merged
Conversation
… to allow all with restricted access to read
Contributor
Author
|
selfie |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… to allow all with restricted access to read
Who is this PR for?
SHS counselors, APs
What problem does this PR fix?
Transition notes were controlled by a feature switch previously, which mostly controlled access to writing. It also incorrectly controlled access to read the restricted section, which should instead just be controlled by
can_view_restricted_notes. Some test setup for this specific endpoint were present, but test cases weren't added.Related to https://rollbar.com/somerville-teacher-tool/studentinsights/items/246/occurrences/93530182055/
What does this PR do?
Changes authorization for accessing the restricted transition note text. This doesn't require access to any labels, but is available for all educators with
can_view_restricted_notes:true.Adds more test cases.
Checklists
Which features or pages does this PR touch?
Does this PR use tests to help verify we can deploy these changes quickly and confidently?