Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transition notes: Add more specs for reading restricted notes, update… #2565

Merged
merged 1 commit into from Aug 28, 2019

Conversation

@kevinrobinson
Copy link
Contributor

kevinrobinson commented Aug 28, 2019

… to allow all with restricted access to read

Who is this PR for?

SHS counselors, APs

What problem does this PR fix?

Transition notes were controlled by a feature switch previously, which mostly controlled access to writing. It also incorrectly controlled access to read the restricted section, which should instead just be controlled by can_view_restricted_notes. Some test setup for this specific endpoint were present, but test cases weren't added.

Related to https://rollbar.com/somerville-teacher-tool/studentinsights/items/246/occurrences/93530182055/

What does this PR do?

Changes authorization for accessing the restricted transition note text. This doesn't require access to any labels, but is available for all educators with can_view_restricted_notes:true.

Adds more test cases.

Checklists

Which features or pages does this PR touch?

  • Student Profile

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Included specs for changes
  • Improved specs for existing code in need of better test coverage
… to allow all with restricted access to read
@kevinrobinson

This comment has been minimized.

Copy link
Contributor Author

kevinrobinson commented Aug 28, 2019

selfie

@kevinrobinson kevinrobinson merged commit 18f0273 into master Aug 28, 2019
1 check was pending
1 check was pending
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@kevinrobinson kevinrobinson deleted the patch/transition-note-restricted-read branch Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.