Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upTransition notes: Update branching in UI for show restricted note #2566
Conversation
This comment has been minimized.
This comment has been minimized.
|
selfie |
kevinrobinson
merged commit 459394b
into
master
1 check was pending
1 check was pending
kevinrobinson
deleted the
patch/second-transition-note-restricted-link-branching
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
kevinrobinson commentedAug 28, 2019
Related to #2565.
Who is this PR for?
SHS counselors and APs
What problem does this PR fix?
#2565 made the authorization more permissive to allow folks with access to view restricted text in transition notes. But the UI code would show the link for folks who didn't have permission, which came up verifying #2565. None of these granted access where it should not have been granted.
What does this PR do?
Updates the UI code to branch, and adds tests for this.
Checklists
Which features or pages does this PR touch?
Does this PR use tests to help verify we can deploy these changes quickly and confidently?