Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transition notes: Update branching in UI for show restricted note #2566

Merged

Conversation

@kevinrobinson
Copy link
Contributor

kevinrobinson commented Aug 28, 2019

Related to #2565.

Who is this PR for?

SHS counselors and APs

What problem does this PR fix?

#2565 made the authorization more permissive to allow folks with access to view restricted text in transition notes. But the UI code would show the link for folks who didn't have permission, which came up verifying #2565. None of these granted access where it should not have been granted.

What does this PR do?

Updates the UI code to branch, and adds tests for this.

Checklists

Which features or pages does this PR touch?

  • Student Profile, inline transition notes

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Included specs for changes
  • Improved specs for existing code in need of better test coverage
@kevinrobinson

This comment has been minimized.

Copy link
Contributor Author

kevinrobinson commented Aug 28, 2019

selfie

@kevinrobinson kevinrobinson merged commit 459394b into master Aug 28, 2019
1 check was pending
1 check was pending
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@kevinrobinson kevinrobinson deleted the patch/second-transition-note-restricted-link-branching branch Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.