Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monitoring: Send error objects to Rollbar separately so it can serialize #2569

Merged
merged 1 commit into from Aug 29, 2019

Conversation

@kevinrobinson
Copy link
Contributor

kevinrobinson commented Aug 29, 2019

JS properties in Error objects are non-enumerable by default, so {error, moreInfo} means Rollbar serializes the error as {}. Update the way we call to keep these separate params.

@kevinrobinson

This comment has been minimized.

Copy link
Contributor Author

kevinrobinson commented Aug 29, 2019

selfie

@kevinrobinson kevinrobinson merged commit 68c2b36 into master Aug 29, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@kevinrobinson kevinrobinson deleted the patch/rollbar-error-objects-isolated branch Aug 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.