Performance: Optimize authorized students query for lower-access users #2574
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Who is this PR for?
educators
What problem does this PR fix?
Optimizes
authorized { Student.all }
style queries. These are used in the home page feed and my students pages, among other places. It came up working on some unrelated features that performance regressed here for folks who fall through to the later lines inwhy_authorized_for_student?
What does this PR do?
Essentially removes
n+1
across students, and moves the query in this method into something that can be eagerly included or cached on theEducator
model or collection, and adds a short-circuit case too.Numbers on
PerfTest.authorized
are pretty clear:Checklists
Which features or pages does this PR touch?
Does this PR use tests to help verify we can deploy these changes quickly and confidently?