Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile insights: Update SHS prioritization to include fall and spring #2575

Merged
merged 1 commit into from Aug 29, 2019

Conversation

@kevinrobinson
Copy link
Contributor

kevinrobinson commented Aug 29, 2019

Who is this PR for?

SHS students, families, educators

What problem does this PR fix?

The fall student voice surveys at SHS aren't showing in the insights box, since previously we favored mid-year reflections if they were present (eg, in the middle of the year). This doesn't make sense at the start of the year, but hadn't been updated yet.

What does this PR do?

Update profile insights box to include fall surveys, and previous year surveys as well. We can make this smarter later, probably should ask for all insights (with timestamps) then sort, or have them express some prioritization.

Checklists

Which features or pages does this PR touch?

  • Student Profile

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Manual testing made more sense here
@kevinrobinson

This comment has been minimized.

Copy link
Contributor Author

kevinrobinson commented Aug 29, 2019

selfie

@kevinrobinson kevinrobinson merged commit 7de09f2 into master Aug 29, 2019
1 check was pending
1 check was pending
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@kevinrobinson kevinrobinson deleted the feature/profile-insights-in-feed-for-fall branch Aug 29, 2019
@kevinrobinson kevinrobinson changed the title Profile insights: Update SHS prioritization Profile insights: Update SHS prioritization to include fall and spring Aug 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.