Repository navigation
Profile insights: Update SHS prioritization to include fall and spring - #2575
Merged
Merged
Conversation
Contributor
Author
|
selfie |
kevinrobinson
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Who is this PR for?
SHS students, families, educators
What problem does this PR fix?
The fall student voice surveys at SHS aren't showing in the insights box, since previously we favored mid-year reflections if they were present (eg, in the middle of the year). This doesn't make sense at the start of the year, but hadn't been updated yet.
What does this PR do?
Update profile insights box to include fall surveys, and previous year surveys as well. We can make this smarter later, probably should ask for all insights (with timestamps) then sort, or have them express some prioritization.
Checklists
Which features or pages does this PR touch?
Does this PR use tests to help verify we can deploy these changes quickly and confidently?