Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Student voice: Update importer to parse id from email properly, add to importers #2580

Merged
merged 3 commits into from Sep 3, 2019

Conversation

@kevinrobinson
Copy link
Contributor

kevinrobinson commented Sep 3, 2019

Fix for #2579.

  • Included specs for changes
  • Improved specs for existing code in need of better test coverage
  • Manual testing made more sense here
@kevinrobinson

This comment has been minimized.

Copy link
Contributor Author

kevinrobinson commented Sep 3, 2019

Add another spec and update to run as thor import task.

@kevinrobinson kevinrobinson changed the title Student voice: Update importer to parse id from email properly Student voice: Update importer to parse id from email properly, add to importers Sep 3, 2019
@kevinrobinson

This comment has been minimized.

Copy link
Contributor Author

kevinrobinson commented Sep 3, 2019

selfie

@kevinrobinson kevinrobinson merged commit ee928a6 into master Sep 3, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@kevinrobinson kevinrobinson deleted the patch/student-voice-email-address-key branch Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.