Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Student voice: Update importer to parse id from email properly, add to importers #2580

Merged
merged 3 commits into from
Sep 3, 2019
Merged

Student voice: Update importer to parse id from email properly, add to importers #2580

merged 3 commits into from
Sep 3, 2019

Conversation

kevinrobinson
Copy link
Contributor

Fix for #2579.

  • Included specs for changes
  • Improved specs for existing code in need of better test coverage
  • Manual testing made more sense here

@kevinrobinson
Copy link
Contributor Author

Add another spec and update to run as thor import task.

@kevinrobinson kevinrobinson changed the title Student voice: Update importer to parse id from email properly Student voice: Update importer to parse id from email properly, add to importers Sep 3, 2019
@kevinrobinson
Copy link
Contributor Author

selfie

@kevinrobinson kevinrobinson merged commit ee928a6 into master Sep 3, 2019
@kevinrobinson kevinrobinson deleted the patch/student-voice-email-address-key branch September 3, 2019 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kevinrobinson