Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Student voice: Add cards into home feed for fall surveys #2581

merged 2 commits into from
Sep 3, 2019


Copy link

@kevinrobinson kevinrobinson commented Sep 3, 2019

Who is this PR for?

SHS students, families, educators

What problem does this PR fix?

Students at SHS are sharing information about themselves that shows up in the profiles, but this isn't discoverable for educators on the home page.

What does this PR do?

Adapts the cards for this from the mid-year student voice surveys, as in #2382. Factors out these from Feed into their own class that it calls.

Screenshot (if adding a client-side feature)

From #2382.


Which features or pages does this PR touch?

  • Home page

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Included specs for changes
  • Manual testing made more sense here

@kevinrobinson kevinrobinson force-pushed the feature/fall-student-survey-home-feed branch from 8608327 to 131299b Compare September 3, 2019 21:47
Copy link
Contributor Author


@kevinrobinson kevinrobinson merged commit 8d06c6f into master Sep 3, 2019
@kevinrobinson kevinrobinson deleted the feature/fall-student-survey-home-feed branch September 3, 2019 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

1 participant