Skip to content

Student voice: Add cards into home feed for fall surveys#2581

Merged
kevinrobinson merged 2 commits into
masterfrom
feature/fall-student-survey-home-feed
Sep 3, 2019
Merged

Student voice: Add cards into home feed for fall surveys#2581
kevinrobinson merged 2 commits into
masterfrom
feature/fall-student-survey-home-feed

Conversation

@kevinrobinson

@kevinrobinson kevinrobinson commented Sep 3, 2019

Copy link
Copy Markdown
Contributor

Who is this PR for?

SHS students, families, educators

What problem does this PR fix?

Students at SHS are sharing information about themselves that shows up in the profiles, but this isn't discoverable for educators on the home page.

What does this PR do?

Adapts the cards for this from the mid-year student voice surveys, as in #2382. Factors out these from Feed into their own class that it calls.

Screenshot (if adding a client-side feature)

From #2382.
image

Checklists

Which features or pages does this PR touch?

  • Home page

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Included specs for changes
  • Manual testing made more sense here

@kevinrobinson kevinrobinson force-pushed the feature/fall-student-survey-home-feed branch from 8608327 to 131299b Compare September 3, 2019 21:47
@kevinrobinson

Copy link
Copy Markdown
Contributor Author

selfie

@kevinrobinson kevinrobinson merged commit 8d06c6f into master Sep 3, 2019
@kevinrobinson kevinrobinson deleted the feature/fall-student-survey-home-feed branch September 3, 2019 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant