Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Student voice: Add cards into home feed for fall surveys #2581

Merged
merged 2 commits into from Sep 3, 2019

Conversation

@kevinrobinson
Copy link
Contributor

kevinrobinson commented Sep 3, 2019

Who is this PR for?

SHS students, families, educators

What problem does this PR fix?

Students at SHS are sharing information about themselves that shows up in the profiles, but this isn't discoverable for educators on the home page.

What does this PR do?

Adapts the cards for this from the mid-year student voice surveys, as in #2382. Factors out these from Feed into their own class that it calls.

Screenshot (if adding a client-side feature)

From #2382.
image

Checklists

Which features or pages does this PR touch?

  • Home page

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Included specs for changes
  • Manual testing made more sense here
@kevinrobinson kevinrobinson force-pushed the feature/fall-student-survey-home-feed branch from 8608327 to 131299b Sep 3, 2019
@kevinrobinson

This comment has been minimized.

Copy link
Contributor Author

kevinrobinson commented Sep 3, 2019

selfie

@kevinrobinson kevinrobinson merged commit 8d06c6f into master Sep 3, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@kevinrobinson kevinrobinson deleted the feature/fall-student-survey-home-feed branch Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.