Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance: Remove authorizer instance variable on ApplicationController #2585

Conversation

@kevinrobinson
Copy link
Contributor

kevinrobinson commented Sep 4, 2019

This is for after #2584 lands.

In #2584, it came up that instance variables on ApplicationController leak across calls to controller actions in rspec tests. This is not how I thought it worked, but turns out all the other uses of tests like this never came across this particular combo. Those kinds of tests are useful for exhaustively testing authorization rules for a given setup (eg across combinations of things like [educator, student]).

This removes the instance variable in ApplicationController related to authorization; it's not doing much there. This has no impact on authorization rules.

…izer-instance-variable-from-application-controller
@kevinrobinson

This comment has been minimized.

Copy link
Contributor Author

kevinrobinson commented Sep 4, 2019

selfie

@kevinrobinson kevinrobinson merged commit 4de9a32 into master Sep 4, 2019
1 check was pending
1 check was pending
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@kevinrobinson kevinrobinson deleted the patch/remove-authorizer-instance-variable-from-application-controller branch Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.