Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upMaintenance: Remove authorizer instance variable on ApplicationController #2585
Conversation
This comment has been minimized.
This comment has been minimized.
|
selfie |
kevinrobinson
deleted the
patch/remove-authorizer-instance-variable-from-application-controller
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
kevinrobinson commentedSep 4, 2019
This is for after #2584 lands.
In #2584, it came up that instance variables on
ApplicationControllerleak across calls to controller actions in rspec tests. This is not how I thought it worked, but turns out all the other uses of tests like this never came across this particular combo. Those kinds of tests are useful for exhaustively testing authorization rules for a given setup (eg across combinations of things like[educator, student]).This removes the instance variable in
ApplicationControllerrelated to authorization; it's not doing much there. This has no impact on authorization rules.